Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simulator, controller): fix inverse pitch calculation #5199

Merged
merged 5 commits into from
Oct 3, 2023
Merged

fix(simulator, controller): fix inverse pitch calculation #5199

merged 5 commits into from
Oct 3, 2023
+508 −2

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 2, 2023 •
edited
Loading

Description

Related links

launcher PR: autowarefoundation/autoware_launch#613

Tests performed

Before this PR

PR5199-2023-10-03_09.48.36.mp4

After this PR

PR5199-2023-10-03_09.45.07.mp4

Notes for reviewers

Interface changes

none.

Effects on system behavior

ego's pitch angle will align with the map slope.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

soblin and others added 3 commits October 2, 2023 18:18
@soblin
fix pitch calculation in simple planning simulator
d5cc4fd 
Signed-off-by: Mamoru Sobue <[email protected]>
@TakaHoribe @soblin
add slope definition in readme
a30bc10 
Signed-off-by: Takamasa Horibe <[email protected]>
@soblin
fix
2a784ae 
Signed-off-by: Mamoru Sobue <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Oct 2, 2023
@soblin soblin mentioned this pull request Oct 2, 2023
Closed
7 tasks
@soblin
fix spell
cfe2cdc 
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin marked this pull request as ready for review October 2, 2023 09:52
@TakaHoribe
Copy link
Contributor

@brkay54 This is a very simple fix for the wrong pitch sign in the simulator reported by you. This may cause a conflict with your PRs, but can we merge this PR?

@brkay54
Copy link
Member

brkay54 commented Oct 2, 2023

@brkay54 This is a very simple fix for the wrong pitch sign in the simulator reported by you. This may cause a conflict with your PRs, but can we merge this PR?

It is better to merge this one before the mine PRs about PID controller. Already I need to make some changes with respect to your review, while doing this I can also solve the conflicts. Thank you @TakaHoribe -san !

@xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 2, 2023
@brkay54
Copy link
Member

brkay54 commented Oct 2, 2023

@TakaHoribe @soblin If everything is okay, can we enable auto-merge?

@soblin
Copy link
Contributor Author

soblin commented Oct 2, 2023 •
edited
Loading

I will make a minor change to the added figure then merge this PR

@soblin
Copy link
Contributor Author

soblin commented Oct 3, 2023

I attached before/after video in the description

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93b6118) 14.77% compared to head (14db08d) 14.78%.
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5199   +/-   ##
=======================================
  Coverage   14.77%   14.78%           
=======================================
  Files        1636     1636           
  Lines      113635   113633    -2     
  Branches    34932    34932           
=======================================
+ Hits        16793    16795    +2     
+ Misses      78001    77998    -3     
+ Partials    18841    18840    -1
Flag Coverage Δ *Carryforward flag
differential 47.17% <50.00%> (?)
total 14.77% <ø> (-0.01%) ⬇️ Carriedforward from cfe2cdc

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...nal_controller/src/pid_longitudinal_controller.cpp 38.72% <100.00%> (ø)
...em_monitor/src/process_monitor/process_monitor.cpp 0.00% <ø> (ø)
...nning_simulator/simple_planning_simulator_core.cpp 37.81% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin enabled auto-merge (squash) October 3, 2023 01:26
@soblin soblin disabled auto-merge October 3, 2023 01:27
@soblin
fix figure
14db08d 
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the fix/fix-invert-pitch-calculation branch from b6c511c to 14db08d Compare October 3, 2023 01:27
@github-actions github-actions bot removed the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 3, 2023
@soblin soblin enabled auto-merge (squash) October 3, 2023 01:34
@soblin soblin merged commit 6e49e82 into autowarefoundation:main Oct 3, 2023
21 of 23 checks passed
@soblin soblin deleted the fix/fix-invert-pitch-calculation branch October 3, 2023 02:05
This was referenced Oct 11, 2023
Merged
Merged
@TakaHoribe TakaHoribe mentioned this pull request Oct 11, 2023
Closed
7 tasks
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Nov 20, 2023
@soblin @TakaHoribe @h-ohta
fix(simulator, controller): fix inverse pitch calculation (autowarefo…
0520afd 
…undation#5199)

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
@h-ohta h-ohta mentioned this pull request Nov 20, 2023
Merged
7 tasks
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Nov 20, 2023
@h-ohta @soblin @TakaHoribe
fix(simulator, controller): fix inverse pitch calculation (backport a…
0b731b4 
…utowarefoundation#5199) (#1025)

fix(simulator, controller): fix inverse pitch calculation (autowarefoundation#5199)

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Mamoru Sobue <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
@HansRobo HansRobo mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@shmpwk shmpwk Awaiting requested review from shmpwk

Assignees
No one assigned
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soblin @TakaHoribe @brkay54 @xmfcx